Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choice weak dependencies #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Choice weak dependencies #45

wants to merge 5 commits into from

Conversation

papoteur-mga
Copy link

@papoteur-mga papoteur-mga commented May 24, 2021 •
edited
Loading

Provides the list of package of a transaction with distinction in to install packages: normal dependencies and weak dependencies

Thus in dnfdragora, the weak dependencies can be displayed separately (see issue #185). An entry 'install_weak' is added in the package dictionnary.

I don't understand why the pull request is not only about the last commit. Surely not clean.

Papoteur and others added 4 commits May 1, 2021 12:35
Improve time spent in _get_id.
c82a0f1 
Before the modification, this function represents 35% of the time spent in get_packages.
After, it is just 30%
Add a specific function for get_packages for standard fields decripti…
38d37e1 
…on, size and group

This give an important improvement in time of GetPackages at start of application and relaod.
Gain is about 20% of the period of loading cache.
Merge branch 'manatools:master' into master
a928553
Provides the list of package of a transaction with distinction in to_…
6a48497 
…install packages: normal dependencies and weak dependencies

Thus in dnfdragora, the weak dependencies can be displayed separately (see issue #185). An entry 'install_weak' is added in the package disctionnary.
@Conan-Kudo Conan-Kudo self-assigned this Jun 2, 2021
@Conan-Kudo Conan-Kudo mentioned this pull request Jun 14, 2021
Merged
@timlau
Copy link
Collaborator

timlau commented Jun 14, 2021

@papoteur-mga can you please rebase this PR on top of master, so it only contains the weak dependencies in transaction changes.
You should use "import libdnf.transaction", not just "import libdnf"
The code is fine, but is is kind of an API break, some of the packages there is returned as being installed, will move to "weak-deps" in the transaction, so changes has to be made in the UI clients, else packages will be installed, but not shown in the UI client transaction result. I have no problems with that and can fix it in yumex-dnf, but dnfdragona properly need changes too.

@Conan-Kudo
Copy link
Member

Breaking the API of dnfdaemon is fine, as we haven't declared a stable API yet. The only other consumer right now is dnfdragora, and we're okay to change it as dnfdaemon changes.

@anaselli
Copy link
Contributor

@timlau do you think we can have a talk about dnfdaemon and (dnf) API, dnfdragora and yumex-dnf it would be great if we could work together on these projects, wdyt?

@timlau
Copy link
Collaborator

timlau commented Jun 14, 2021

@anaselli fine with me,feel free to mail me.
I have started to make a new a dnf-dbus API from scratch
https://github.com/timlau/dnf-dbus
It is very early in development, but when it matures and get more feature complete it might be an replacement for dnfdaemon with a more modern code base there is easier to maintain and don't break every-time some dnf internals changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Conan-Kudo Conan-Kudo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@papoteur-mga @timlau @Conan-Kudo @anaselli